PHP Mail

[jdiben]

I found the following code that works very well at sending a contact form to an email address (after the form variables are added to the $body variable). Is there a reason that I should not use this? I am currently using matts formmail script, and it works fine but I would like to use the php code below. What are the advantages/disadvantages of using the code below?

<?php
		$from=$HTTP_POST_VARS['fromName'];
		$to="Webmaster";
		$eMail=$HTTP_POST_VARS['fromEmail'];
		$eMailto="webmaster@mysite.com";
		$subject="Subject goes here";
		$body="Body goes here";
		$userip = ($_SERVER['X_FORWARDED_FOR']) ? $_SERVER['X_FORWARDED_FOR'] : $_SERVER['REMOTE_ADDR'];
		mail( '"' . $to . '" <' . $eMailto . '>',
			   $subject, $body,
			   'Return-Path: "' . $from . '" <' . $eMail . ">\n"
			   . 'From: "' . $from . '" <' . $eMail . ">\n"
			   . 'Reply-To: "' . $from . '" <' . $eMail . ">\n"
			   . "X-Mailer: PHP/" . phpversion() . "\n"
			   . "X-From-IP: " . $userip );
?>

Thanks
Joe

[jamal]

Hi jdiben;
the code below will work fine as you mentioned.
In PHP 4.1+ the autoglobal $_POST has been introduced, ($HTTP_POST_VARS is not autoglobal), this is not a big deal right now, but it is recommended that you start using $_POST instead of $HTTP_POST_VARS, they are different variables. See:
http://www.php.net/manual/en/reserve...variables.post

Also I've read somewhere (don't quote me on this) that it is not recommended that you use the "Person's Name <email@example.com>" syntax, but instead use the email address by itself.

Thats all, other than that, this one also returns the php version and mailers IP address as you may know already.

Yours,
Jamal