Quote:
|
Originally Posted by lindsay
I have done as much cleanup that I can do and would love your advice and comments.
|
Nice, clean look! Good "theming".
But "under the hood" you could cleanup some other issues as well:
- the ID "designs" is assigned twice
- you should mask your ampersands: & --> &
- your handling of IMG looks rather spammy:
Code:
[img]Images/styles.jpg[/img]
Additionally, this is not how the ALT tag is supposed to be used: It is meant to give functional information for text-only-browsers or UAs with graphics turned off.
- the "pre-order envelopes" graphic has no link. I guess it should have one.
- "birth announcements" leads to a flash page without prior warning. I would at least add a link title "Flash required".
(this could be done in pure CSS, btw)
- it is confusing that what looks like a horizontal menu bar is just a tag line. The font style is the same as the text links in the left nav bar. Try to make it look a bit different, at least add a rollover (preferably CSS) as Marcie said.
- mix of CSS and unneccesary inline formatting:
<p align="center" class="regular2">
<td align="left" valign="middle" bgcolor="#FFFFFF" class="regular">
etc. etc.
Better put all formatting in your external CSS - site maintainance will be much easier. And the page will render faster.
- you really do not need constructs like
Code:
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
</p>
<p align="center">
or
Code:
<tr>
<td align="center" valign="middle" bgcolor="#FFFFFF"></td>
</tr>
This only bloats your code. Apply whitspace using CSS. Better put all formatting in your external CSS - site maintainance will be much easier (do I sound repetitive?).
In general, taking out all direct formatting and putting it in external CSS, you can reduce your code by (estimated) 50%. Did I say that it will be easier to maintain?
Also, you could do a bit about the 100k overall file size which makes the page load slow on low bandwidth connections.
From a typographical point of view: Don't center the main body text.
hth,
faglork
PS: I bet it was done in Dreamweaver ;-)