new website for review, error

incrediblehelp · #1 (**permalink**) 12-19-2005, 03:19 PM

Hello everyone. I was completing a new website for my ole high school hockey team:

http://www.northviewhockey.com/

I am getting a javascript error in IE 6:

Error: Object Expected.

Any one has an idea what it is?

Tim · #2 (**permalink**) 12-19-2005, 04:53 PM

It looks like you have 3 heads! In the first you have missed out the meta closures ( /> ) and that could have a big effect. But it gets worse, in the first few lines of that <body> you repeated the DOCTYPE and open a new <head> with the MM Javascript. Further down the page, below the navigation code you closed </body> and </html> but continue with a new row <tr> and so on...

Further down the page you repeat DOCTYPE and a new head again!

I suspect that you don't have a JavaScript error at all but that your XHTML is a dog's dinner!

incrediblehelp · #3 (**permalink**) 12-19-2005, 05:16 PM

What the heck, your right. I am calling the correct head from another file, must have left the header in there. Looking at it further.

incrediblehelp · #4 (**permalink**) 12-19-2005, 05:23 PM

Yeah I was calling a header and footer and left the meta tags in both of those so the pages were producing multiple (3) meta tags.

incrediblehelp · #5 (**permalink**) 12-19-2005, 05:49 PM

removed the meta tags, duh...still getting an error. Any ideas. I am not much of a designer and I am just learning PHP.

Tim · #6 (**permalink**) 12-19-2005, 06:29 PM

You still haven't closed the meta tags eg.;

...Sylvania, Ohio"> should be;
...Sylvania, Ohio" />

for both keywords and description.

Also, just above <table id="footer"... is a repeat of the MM JavaScript which should be in the <head> and just below that a re-opening of <body> with onLoad="MM_preloadImages...

You're getting there though! :)

Tim · #7 (**permalink**) 12-19-2005, 07:13 PM

Here are some more cleaning jobs. Your head should look like this;

<head>
<title>Northview Wildcats Hockey - Sylvania, Ohio</title>
<meta name="description" content="Northview Wildcats Hockey - Sylvania, Ohio" />
<meta name="keywords" content="Northview Wildcats Hockey - Sylvania, Ohio" />
<meta http-equiv="content-type" content="text/html; charset=iso-8859-1" />
<link href="style.css" rel="stylesheet" type="text/css" />
</head>

instead of this;

<head>
<title>Northview Wildcats Hockey - Sylvania, Ohio</title>
<meta NAME="description" content="Northview Wildcats Hockey - Sylvania, Ohio">
<meta NAME="keywords" content="Northview Wildcats Hockey - Sylvania, Ohio">
<LINK REL=StyleSheet HREF="style.css" TYPE="text/css">
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
</head>

ie. no uppercase in XHTML syntax and you must include XHTML closures on tags.

Also, there is no table height (eg. height="100%") attribute for any current version of HTML.

On line 91 there is a typo valing="top" which I think you intended to be valign="top" applied to a table. I don't think that's valid though.

There are other bits 'n' bobs but let's focus on getting rid of the JavaScript error. I still think its the head and body mix-up that's throwing up the error.

incrediblehelp · #8 (**permalink**) 12-19-2005, 07:16 PM

boot,

I have never used a closing tag like that in my keywords and description tag. I dont think it has any effect adding it.

Also you feel that uppercase makes a difference?

Tim · #9 (**permalink**) 12-19-2005, 07:22 PM

Yes, in XHTML. Try the tag closures too.

Tim · #10 (**permalink**) 12-19-2005, 07:29 PM

Popups are very unpopular anyway, why bother?

incrediblehelp · #11 (**permalink**) 12-19-2005, 07:32 PM

yeah removed the onload commands. It wasnt for a popup, just a command Dreamweaver added when I added image rollovers.

Please review again.

Tim · #12 (**permalink**) 12-19-2005, 08:21 PM

Jaan, the error messages in IE and Firefox are different. There is a possible problem with http://www.northviewhockey.com/blog/...ndar3/popup.js which is not an automatic addition by Dreamweaver.

According to the JavaScript console in my Firefox, on line 9 of that script the WindowOnload is not defined.

You still have a bunch of Dreamweaver JavaScript just above the footer table. This is duplicate and does not belong in the body. I really think you should clean up the code first before trying to identify possible JavaScript errors. JavaScript is very particular about the environment around it. An error within the HTML or other JavaScript inclusions can totally mess it up and throw up bogus messages.

Why are you so resistant to closing those still-open meta tags?

It's nearly 1am here and I need to go to bed! Anyone else want to take over here?

;o

Tim · #13 (**permalink**) 12-19-2005, 09:06 PM

You might find some useful tips about the calendar script at http://blog.firetree.net/2005/07/18/eventcalendar-30/ but this is more than likely where you got it from. I'm now suspecting that there's a PHP error as well.

Good night.

incrediblehelp · #14 (**permalink**) 12-19-2005, 09:29 PM

Thanks for the help thus far bootboy and I will look at the calendar code for cause of the error.

As far as the closing of the tags are concerned I just never, ever saw someone close keyword and description tab in that manner or at least make it common practive to do so. Anyone else see this?

Tim · #15 (**permalink**) 12-20-2005, 06:15 AM

If you take a look your code Jaan, you will see that every tag below your head has proper XML closures ( />). The html starts right up at the top of the page after the DTD, hence every tag in the html should have a proper closure, including in the head. I'm not a standards geek or xml fetishist or even just a bit weird (!), it' just the proper way to do it.
Don't take my word for it, read what WebMonkey have to say and 'the horses mouth' W3C.

I like the Wildcat's site. It's bold and clear and easy to navigate. It'll be better when it's finished, without the 'coming soons', with the missing alt tags filled and the numerous code errors fixed. As an SEO expert you will realise the importance of those. Also, in that respect you might want to utilise the H1 tag on your homepage that has currently only got a space in it and make the alt tag of the image of huddled players more relevant than simply 'Jim Cooper'. Summaries for your tables would make the site more accessible to those with text-based browsers, including search engines. Good SEO article here.

Every page generates lots of JavaScript warnings that appear to be associated with code 301 errors for the Yahoo and Google ads. Seems the targets have moved.

Good luck mate.

Tim

incrediblehelp · #16 (**permalink**) 12-20-2005, 11:22 AM

Quote:

Originally Posted by Bootboy

If you take a look your code Jaan, you will see that every tag below your head has proper XML closures ( />). The html starts right up at the top of the page after the DTD, hence every tag in the html should have a proper closure, including in the head. I'm not a standards geek or xml fetishist or even just a bit weird (!), it' just the proper way to do it.
Don't take my word for it, read what WebMonkey have to say and 'the horses mouth' W3C.

I like the Wildcat's site. It's bold and clear and easy to navigate. It'll be better when it's finished, without the 'coming soons', with the missing alt tags filled and the numerous code errors fixed. As an SEO expert you will realise the importance of those. Also, in that respect you might want to utilise the H1 tag on your homepage that has currently only got a space in it and make the alt tag of the image of huddled players more relevant than simply 'Jim Cooper'. Summaries for your tables would make the site more accessible to those with text-based browsers, including search engines. Good SEO article here.

Every page generates lots of JavaScript warnings that appear to be associated with code 301 errors for the Yahoo and Google ads. Seems the targets have moved.

Good luck mate.

Tim

I will look into the closing tags more. I understand proper validation is a good thing, but not absolutely necessary to rank. In fact SEO is not a big part of this website. I am just learning (or trying to learn) some PHP will working through this.

Of course the whole website is not full with content yet and I waiting for much of it from the players and parents.

As far as I can tell I am using a H1 tag fine on the home page:

<h1 align="left">Alumni Game Set For December 23rd</h1>

I am not sure what you mean on the 301 errors for the Google code. Looks fine to me.

One good thing to know the team is 12-0 this year and the best high school hockey team in Ohio!

Thanks Tim!

Tim · #17 (**permalink**) 12-20-2005, 01:43 PM

Hi Jaan,

It's this H1 I was referring to;

<div align="center">[img]images/alumni.jpg[/img]
The Old Guard</div>
</div>

<h1 align="left"></h1>
<div align="center" valign="top"><div><div>
<div align="left">

</div>

You can see the '301' warnings at the W3C Link Checker. I don't know how important they are but I'd hate you to be missing out.

I understand that you are learning and am just trying to help that process. We are all on some sort of learning curve with this ever changing merry-go-round. I hope you don't think I'm being hard on you or finding faults unecessarily, I'm just pointing out what I see and to that extent I'm learning too.

Are the Wildcats better now than when you played for them in 1992?

Many regards,

Tim

incrediblehelp · #18 (**permalink**) 12-20-2005, 02:01 PM

Your not hard on me at all. Keep it coming. Most of these errors are very minor, but I love you helping me catch all of them.

We were not very good in 1992. I actually still play and we have a yearly Alumni game this Friday that I will be playing in. I will get to see all the old guys again.

Also those errors are normal for Google AdSense and the the Yahoo 301 errors are from Yahoo News links that are OK as well.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode